Post by JNeuhoff » Wed Jan 28, 2009 8:29 pm

This is what I get when using Konqueror Version 4.1.3 (KDE 4.1.3), the same with Firefox 3.0.5 when zooming out one level.

Attachments

???
opencart-0-7-9rc8-layout.png
Last edited by JNeuhoff on Wed Jan 28, 2009 8:31 pm, edited 1 time in total.

Export/Import Tool * SpamBot Buster * Unused Images Manager * Instant Option Price Calculator * Number Option * Google Tag Manager * Survey Plus * OpenTwig


User avatar
Guru Member

Posts

Joined
Wed Dec 05, 2007 3:38 am


Post by hm2k » Wed Jan 28, 2009 10:28 pm

The problem is purely down to the template. The default template HTML markup and css simply isn't as good as it could be.

Our intention was to introduce a new default template in 0.8, and leave 0.7.9's how it is for now.

Since this isn't a "major" bug, certainly not a core code bug, it's purely cosmetic, and not many people will zoom out anyway, it's unlikely that we're going to tackle this issue in 0.7.9.

There may be a simple solution, but I'm not convinced it will work in all situations, I'm on the understanding that quite a few changes would be required in order to get this to work suitably.

As always, we invite you to submit your templates as contributions.

This issue will be tackled in 0.8 with the introduction of a new default template.

UK Web Hosting


User avatar
Global Moderator

Posts

Joined
Tue Mar 11, 2008 9:06 am
Location - UK

Post by Qphoria » Wed Jan 28, 2009 10:32 pm

From my testing with FF's ctrl+scrollwheel zooming, if you change the #content width from 581px to 578px it keeps position from the smallest to the largest possible sizes

EDIT: catalog/template/default/css/default.css

FIND:
#content {
margin: 10px 0px 15px 0px;
float: right;
padding-left: 15px;
border-left: 1px solid #EEEEEE;
width: 581px;
}

REPLACE WITH:
#content {
margin: 10px 0px 15px 0px;
float: right;
padding-left: 15px;
border-left: 1px solid #EEEEEE;
width: 578px;
}

We would rather not have to make an RC9 just for this, unless there are other code bugs found in RC8, then we can perhaps change this as well. We'll play it by ear, but this should at least quickly fix the issue.

Image


User avatar
Administrator

Posts

Joined
Tue Jul 22, 2008 3:02 am

Post by JNeuhoff » Thu Jan 29, 2009 1:20 am

width: 578px;
It's only a partial fix for FireFox, and none for Konqueror.
We would rather not have to make an RC9 just for this, unless there are other code bugs found in RC8
If I can find some time this coming weekend, I might do a proper fix. The current default.css has some strange entries, such as

Code: Select all

#container {
	width: 779px;
	position: relative;
	left: 50%;
	margin-left: -389px;
}

I'd rather use a center-aligned fixed-width #container as a starting point, e.g. something like

Code: Select all

body    { font-family:Verdana, Arial, Helvetica, sans-serif; font-size:13px; background-color:white; margin:0 0 0 0; padding:0 0 0 0; color:#234; } 
......
#container {
	position:relative;
	display:block;
	width:75em;
	min-width:975px;
	margin: 5px auto 0 auto;
	padding:0 0 0 0;
}

* html #container {
	position:relative;
	width:975px;
}
......
Anyway, don't delay the final release because of this.
Last edited by JNeuhoff on Thu Jan 29, 2009 1:25 am, edited 1 time in total.

Export/Import Tool * SpamBot Buster * Unused Images Manager * Instant Option Price Calculator * Number Option * Google Tag Manager * Survey Plus * OpenTwig


User avatar
Guru Member

Posts

Joined
Wed Dec 05, 2007 3:38 am


Post by JNeuhoff » Sat Jan 31, 2009 12:37 am

I have created an updated default template, with some of the CSS and TPL files fixed, using a centered-aligned #container and left-floated #column and #content. Tested with:

IE6
Opera 9.63
FireFox 3.05
Konqueror 4.1.3

Feel free to integrate it into the Opencart 0.7.9final, or else I can upload this patch in the contributions sections.

Attachments


Export/Import Tool * SpamBot Buster * Unused Images Manager * Instant Option Price Calculator * Number Option * Google Tag Manager * Survey Plus * OpenTwig


User avatar
Guru Member

Posts

Joined
Wed Dec 05, 2007 3:38 am

Who is online

Users browsing this forum: No registered users and 12 guests