Page 1 of 1

[v3.0.2.0 - Concept] - BRs insteads of BR slash

Posted: Wed Oct 04, 2017 4:13 am
by straightlight
The following files contains HTML codes with:

Code: Select all

<br>
instead of:

Code: Select all

<br />

Code: Select all

admin/view/template/marketplace/marketplace_info.twig
install/view/template/3rd_party/maxmind.twig
install/view/template/3rd_party/openbay.twig
install/view/template/install/step_1.twig
install/view/template/install/step_2.twig
install/view/template/install/step_3.twig
install/view/template/install/step_4.twig
install/view/template/upgrade/upgrade.twig
admin/view/template/extension/payment/divido.twig
admin/view/template/extension/payment/laybuy_order.twig
admin/view/template/extension/payment/laybuy_transaction.twig
catalog/view/theme/default/template/information/contact.twig
catalog/view/theme/default/template/extension/module/amazon_login.twig
catalog/view/theme/default/template/extension/module/amazon_pay.twig
catalog/view/theme/default/template/extension/payment/amazon_login_pay_address.twig
catalog/view/theme/default/template/extension/payment/amazon_login_pay_confirm.twig
catalog/view/theme/default/template/extension/payment/amazon_login_pay_payment.twig
Nothing crucial. Although, a bit odd without the slash as not providing the right example to the zillion of theme developers since there are 65 files that those use it:

Code: Select all

admin/view/template/common/filemanager.twig
admin/view/template/common/footer.twig
admin/view/template/common/forgotten.twig
admin/view/template/common/login.twig
admin/view/template/common/reset.twig
admin/view/template/customer/customer_form.twig
admin/view/template/customer/custom_field_form.twig
admin/view/template/design/banner_form.twig
admin/view/template/design/theme.twig
admin/view/template/marketing/marketing_form.twig
admin/view/template/marketplace/installer.twig
admin/view/template/marketplace/marketplace_comment.twig
admin/view/template/marketplace/marketplace_info.twig
admin/view/template/marketplace/marketplace_list.twig
admin/view/template/sale/order_form.twig
admin/view/template/sale/order_info.twig
admin/view/template/sale/order_invoice.twig
admin/view/template/sale/order_shipping.twig
admin/view/template/sale/return_form.twig
admin/view/template/setting/setting.twig
admin/view/template/setting/store_form.twig
admin/view/template/user/api_form.twig
install1/view/template/common/footer.twig
admin/view/template/extension/dashboard/activity_info.twig
admin/view/template/extension/dashboard/map_info.twig
admin/view/template/extension/feed/google_base.twig
admin/view/template/extension/openbay/amazonus_bulk_linking.twig
admin/view/template/extension/openbay/amazonus_listing.twig
admin/view/template/extension/openbay/amazon_bulk_linking.twig
admin/view/template/extension/openbay/amazon_listing.twig
admin/view/template/extension/openbay/amazon_settings.twig
admin/view/template/extension/openbay/ebay_item_link.twig
admin/view/template/extension/openbay/ebay_new.twig
admin/view/template/extension/openbay/fba_order_info.twig
admin/view/template/extension/openbay/openbay_itemlist.twig
admin/view/template/extension/payment/pp_braintree_preferred.twig
admin/view/template/extension/payment/pp_express.twig
admin/view/template/extension/payment/pp_express_search.twig
admin/view/template/extension/payment/pp_payflow_iframe_order.twig
admin/view/template/extension/payment/squareup_recurring_buttons.twig
catalog/view/theme/default/template/account/order_info.twig
catalog/view/theme/default/template/account/recurring_info.twig
catalog/view/theme/default/template/account/return_info.twig
catalog/view/theme/default/template/checkout/cart.twig
catalog/view/theme/default/template/checkout/confirm.twig
catalog/view/theme/default/template/checkout/guest.twig
catalog/view/theme/default/template/checkout/payment_address.twig
catalog/view/theme/default/template/checkout/register.twig
catalog/view/theme/default/template/checkout/shipping_address.twig
catalog/view/theme/default/template/common/cart.twig
catalog/view/theme/default/template/information/contact.twig
catalog/view/theme/default/template/mail/order_add.twig
catalog/view/theme/default/template/product/category.twig
catalog/view/theme/default/template/product/compare.twig
catalog/view/theme/default/template/product/product.twig
catalog/view/theme/default/template/extension/module/laybuy_layout.twig
catalog/view/theme/default/template/extension/module/store.twig
catalog/view/theme/default/template/extension/payment/amazon_login_pay_confirm.twig
catalog/view/theme/default/template/extension/payment/cheque.twig
catalog/view/theme/default/template/extension/payment/eway.twig
catalog/view/theme/default/template/extension/payment/klarna_account.twig
catalog/view/theme/default/template/extension/payment/klarna_checkout_sidebar.twig
catalog/view/theme/default/template/extension/payment/pp_braintree.twig
catalog/view/theme/default/template/extension/payment/pp_braintree_confirm.twig
catalog/view/theme/default/template/extension/payment/pp_express_confirm.twig

Re: [v3.0.2.0 - Concept] - BRs insteads of BR slash

Posted: Wed Oct 04, 2017 6:19 pm
by RuslanBrest
straightlight wrote:
Wed Oct 04, 2017 4:13 am
Nothing crucial. Although, a bit odd without the slash as not providing the right example to the zillion of theme developers
Current DOCTYPE used in all pages of Opencart is HTML5. The "BR" element must be `<br>`, not `<br />`.
See https://www.w3.org/TR/html5/text-level- ... br-element

The `<br />` is valid for XHTML doctype.

Re: [v3.0.2.0 - Concept] - BRs insteads of BR slash

Posted: Wed Oct 04, 2017 7:39 pm
by straightlight
Possibly, which is why I posted both versions of the files in comparison above to demonstrate that two different sets of BRs are currently being used and shouldn't be. ;)