Post by straightlight » Tue Oct 03, 2017 3:51 am

This subject may have been discussed in the past. Although, it may be best to check all the files involving the alert command as it is really not suggested to use in a production network for all users but only as administrators or in a development network.

In the following files and the ... smallest list of files ever posted:

Code: Select all

admin/view/template/catalog/download_form.twig
admin/view/template/common/dashboard.twig
admin/view/template/common/developer.twig
admin/view/template/common/filemanager.twig
admin/view/template/common/security.twig
admin/view/template/customer/customer_approval.twig
admin/view/template/customer/customer_form.twig
admin/view/template/design/theme.twig
admin/view/template/design/translation_form.twig
admin/view/template/localisation/geo_zone_form.twig
admin/view/template/marketing/contact.twig
admin/view/template/marketplace/api.twig
admin/view/template/marketplace/extension.twig
admin/view/template/marketplace/installer.twig
admin/view/template/marketplace/marketplace_info.twig
admin/view/template/marketplace/marketplace_list.twig
admin/view/template/marketplace/openbay.twig
admin/view/template/sale/order_form.twig
admin/view/template/sale/order_info.twig
admin/view/template/sale/order_list.twig
admin/view/template/sale/voucher_form.twig
admin/view/template/sale/voucher_list.twig
admin/view/template/setting/setting.twig
admin/view/template/setting/store_form.twig
admin/view/template/tool/backup.twig
admin/view/template/user/api_form.twig
admin/view/template/extension/dashboard/chart_info.twig
admin/view/template/extension/dashboard/map_info.twig
admin/view/template/extension/feed/google_base.twig
admin/view/template/extension/fraud/ip.twig
admin/view/template/extension/openbay/amazonus_ajax_shippinginfo.twig
admin/view/template/extension/openbay/amazonus_bulk_linking.twig
admin/view/template/extension/openbay/amazonus_bulk_listing.twig
admin/view/template/extension/openbay/amazonus_item_links.twig
admin/view/template/extension/openbay/amazonus_listing.twig
admin/view/template/extension/openbay/amazonus_listing_advanced.twig
admin/view/template/extension/openbay/amazonus_saved_listings.twig
admin/view/template/extension/openbay/amazon_ajax_shippinginfo.twig
admin/view/template/extension/openbay/amazon_bulk_linking.twig
admin/view/template/extension/openbay/amazon_bulk_listing.twig
admin/view/template/extension/openbay/amazon_item_links.twig
admin/view/template/extension/openbay/amazon_listing.twig
admin/view/template/extension/openbay/amazon_listing_advanced.twig
admin/view/template/extension/openbay/amazon_saved_listings.twig
admin/view/template/extension/openbay/ebay_edit.twig
admin/view/template/extension/openbay/ebay_item_import.twig
admin/view/template/extension/openbay/ebay_item_link.twig
admin/view/template/extension/openbay/ebay_new.twig
admin/view/template/extension/openbay/ebay_new_bulk.twig
admin/view/template/extension/openbay/ebay_order_import.twig
admin/view/template/extension/openbay/ebay_profile_form_shipping.twig
admin/view/template/extension/openbay/ebay_settings.twig
admin/view/template/extension/openbay/ebay_subscription.twig
admin/view/template/extension/openbay/ebay_summary.twig
admin/view/template/extension/openbay/ebay_syncronise.twig
admin/view/template/extension/openbay/ebay_usage.twig
admin/view/template/extension/openbay/etsy_create.twig
admin/view/template/extension/openbay/etsy_edit.twig
admin/view/template/extension/openbay/etsy_links.twig
admin/view/template/extension/openbay/etsy_listings.twig
admin/view/template/extension/openbay/etsy_settings.twig
admin/view/template/extension/openbay/openbay_itemlist.twig
admin/view/template/extension/openbay/openbay_manage.twig
admin/view/template/extension/openbay/openbay_orderlist_confirm.twig
admin/view/template/extension/payment/amazon_login_pay_order.twig
admin/view/template/extension/payment/bluepay_hosted_order.twig
admin/view/template/extension/payment/bluepay_redirect_order.twig
admin/view/template/extension/payment/eway_order.twig
admin/view/template/extension/payment/firstdata_order.twig
admin/view/template/extension/payment/firstdata_remote_order.twig
admin/view/template/extension/payment/g2apay_order.twig
admin/view/template/extension/payment/globalpay_order.twig
admin/view/template/extension/payment/globalpay_remote_order.twig
admin/view/template/extension/payment/klarna_checkout.twig
admin/view/template/extension/payment/klarna_checkout_order_ajax.twig
admin/view/template/extension/payment/laybuy_order.twig
admin/view/template/extension/payment/laybuy_transaction.twig
admin/view/template/extension/payment/pp_braintree.twig
admin/view/template/extension/payment/pp_payflow_iframe_order.twig
admin/view/template/extension/payment/pp_payflow_iframe_refund.twig
admin/view/template/extension/payment/pp_pro_iframe_order.twig
admin/view/template/extension/payment/realex_order.twig
admin/view/template/extension/payment/realex_remote_order.twig
admin/view/template/extension/payment/sagepay_direct_order.twig
admin/view/template/extension/payment/sagepay_server_order.twig
admin/view/template/extension/payment/securetrading_pp_order.twig
admin/view/template/extension/payment/securetrading_ws_order.twig
admin/view/template/extension/payment/squareup_recurring_buttons.twig
admin/view/template/extension/payment/worldpay_order.twig
catalog/view/theme/default/template/account/address_form.twig
catalog/view/theme/default/template/account/affiliate.twig
catalog/view/theme/default/template/account/edit.twig
catalog/view/theme/default/template/account/register.twig
catalog/view/theme/default/template/affiliate/register.twig
catalog/view/theme/default/template/checkout/checkout.twig
catalog/view/theme/default/template/checkout/guest.twig
catalog/view/theme/default/template/checkout/guest_shipping.twig
catalog/view/theme/default/template/checkout/payment_address.twig
catalog/view/theme/default/template/checkout/register.twig
catalog/view/theme/default/template/checkout/shipping_address.twig
catalog/view/theme/default/template/information/tracking.twig
catalog/view/theme/default/template/product/product.twig
catalog/view/theme/default/template/extension/payment/amazon_login_pay_address.twig
catalog/view/theme/default/template/extension/payment/authorizenet_aim.twig
catalog/view/theme/default/template/extension/payment/bank_transfer.twig
catalog/view/theme/default/template/extension/payment/bluepay_redirect.twig
catalog/view/theme/default/template/extension/payment/cardconnect.twig
catalog/view/theme/default/template/extension/payment/cheque.twig
catalog/view/theme/default/template/extension/payment/cod.twig
catalog/view/theme/default/template/extension/payment/eway_iframe.twig
catalog/view/theme/default/template/extension/payment/klarna_checkout_sidebar.twig
catalog/view/theme/default/template/extension/payment/perpetual_payments.twig
catalog/view/theme/default/template/extension/payment/pp_braintree.twig
catalog/view/theme/default/template/extension/payment/pp_payflow.twig
catalog/view/theme/default/template/extension/payment/pp_pro.twig
catalog/view/theme/default/template/extension/payment/sagepay_direct.twig
catalog/view/theme/default/template/extension/payment/sagepay_server.twig
catalog/view/theme/default/template/extension/payment/sagepay_us.twig
catalog/view/theme/default/template/extension/payment/web_payment_software.twig
catalog/view/theme/default/template/extension/payment/wechat_pay_qrcode.twig
catalog/view/theme/default/template/extension/payment/worldpay.twig
catalog/view/theme/default/template/extension/recurring/pp_express.twig
catalog/view/theme/default/template/extension/recurring/squareup.twig
catalog/view/theme/default/template/extension/total/coupon.twig
catalog/view/theme/default/template/extension/total/reward.twig
catalog/view/theme/default/template/extension/total/shipping.twig
catalog/view/theme/default/template/extension/total/voucher.twig
Find all instances of:

Code: Select all

alert(
replace , each, with:

Code: Select all

alert(thrownError + "\r\n" + xhr.statusText + "\r\n" + xhr.responseText);
Last edited by straightlight on Fri Jan 26, 2018 7:38 am, edited 1 time in total.

The most generated errors being found on Opencart forum originates from contributed programming.

Regards,
Straightlight


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by JNeuhoff » Thu Jan 25, 2018 6:35 pm

I don't agree with your proposal. Merely commenting out the Javascript alert calls isn't enough. If there are failed Ajax calls then this is a serious condition, e.g. it could be a sign that the server is down. and for these circumstances the end user should see a clear error message on his screen!

MHC Web Design
Override Engine * Integrated VQMod * Multilingual SEO * Instant Option Price Calculator * TrustPilot Reviews * Download Options * Free Download Buttons * Export/Import Tool * Template Switcher PHP/Twig


User avatar
Expert Member

Posts

Joined
Wed Dec 05, 2007 3:38 am


Post by straightlight » Fri Jan 26, 2018 7:36 am

They should be replaced with the three triggers for detailed reports as explained on Github from Daniel. My first post is indeed what this is about but I should of used the replaced statement as a solution rather than commenting out the line as a solution.

The most generated errors being found on Opencart forum originates from contributed programming.

Regards,
Straightlight


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON
Who is online

Users browsing this forum: No registered users and 6 guests