The client has a user-group Trade-A. A product has a discounted price for customer group Trade-A. All works well when a visitor in the customer group logs into the front of the store and places an order, the discounted product price is used, however :
When the client receives a telephone order from a customer in customer group Trade-A and enters an order manually within the admin system, selecting the correct customer group for that telephone client the discounted price for the product is not used, but the products standard none discounted price.
Comments, advice, help welcome
Regards.
Dab
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
In addition I could not find any reference to this in GitHub. Please give git ref or post link.
Anyone know of an extension that will allow site owner to create manual orders that take account of customer group product discounts?
Regards.
Dab.
Nowhere to be said on my previous reply that a mentioned fix has been posted but I did addressed the issue prior and did mentioned on my previous reply a hope to be seen as a fix solution for the next release. Indicating that a fix for this issue has not been applied, however, would be inaccurate information for users unless you are working with the dev team which, doubtfully, they would address these issues on the Bug Reports section of the forum. In addition, the code tab on GitHub may show relative fix to what you are looking for even though no reports have been posted about it.There appears to be no mention of a fix for this issue in the 3.1 Alpha release!
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
It's probably best that I not add more!
Dab
Regards.
Dab
has been changed to:if (is_array($this->config->get('config_customer_group_display')) && in_array($this->request->post['customer_group_id'], $this->config->get('config_customer_group_display'))) {
Code: Select all
if (in_array($this->request->post['customer_group_id'], (array)$this->config->get('config_customer_group_display'))) {
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
We just need do some adjustment on admin dashboard, no coding at all ( i tried all the coding solution, always got errors ).
It's not bug issue for me, It just I failed to understand all the basic features in opencart .
Here the setting steps :
1. at admin dashboard - go to system > setting > edit your store > tab option
2. find setting "Customer Groups" - tick all your existing groups
then you can edit customer order without changing the discounted price
Hope this can use to solve this problem
I am using version 3.0.3.1 now, the issue persists, can someone confirm these changes have not been added to the latest release?
Please if someone can tell me, do I need to delete (comment out) the full 2 lines
if (is_array($this->config->get('config_customer_group_display')) && in_array($this->request->post['customer_group_id'], $this->config->get('config_customer_group_display'))) {
And replace with:
if (in_array($this->request->post['customer_group_id'], (array)$this->config->get('config_customer_group_display'))) {
What file are these lines in?
Is danijelGombac's solution an alternative to this solution?, which is better?
All files containing these lines. Use TextCrawler to track all the relative files.What file are these lines in?
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
Can you show when/where this was changed?straightlight wrote: ↑Tue Sep 11, 2018 12:08 amThe array validations have been recently fixed entirely by Daniel on GitHub.
has been changed to:if (is_array($this->config->get('config_customer_group_display')) && in_array($this->request->post['customer_group_id'], $this->config->get('config_customer_group_display'))) {
as it has proved to be effective since. However, the enquiry you have addressed this issue is indeed in the right one on the forum.Code: Select all
if (in_array($this->request->post['customer_group_id'], (array)$this->config->get('config_customer_group_display'))) {
There's no change in the master branch on githuib. I checked a few other branches and could find no evidence of this change anywhere. It seems PR #6855 is closed but has never been merged.
So, has this ever actually been fixed?
If not, which fix is most appropriate? The one you show, or the one in #6855?
Code: Select all
if (!empty($this->request->post['customer_group_id']) && $this->config->has('config_customer_group_display') && is_array($this->config->get('config_customer_group_display')) && in_array($this->request->post['customer_group_id'], $this->config->get('config_customer_group_display'))) {
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
Your new, third, "fix" does not work.
Only the fix in #6855 seems to work but this has never been merged as far as I can tell.
That's because the two possible explanations where:
1 - It has been reported with those "doesn't work" replies.
2 - It has never been confirmed prior to your post on this day which ones was the actual solution based on specific requests / problems.
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
Users browsing this forum: No registered users and 6 guests