Problem with Image Manager

straightlight wrote:

I've already had a post about it: http://forum.opencart.com/viewtopic.php?f=188&t=163914

It indicates in your last response that you would try it but no results were posted afterwards. Would it be possible to post more details about this?

R_D wrote:

straightlight wrote:

I've already had a post about it: http://forum.opencart.com/viewtopic.php?f=188&t=163914

It indicates in your last response that you would try it but no results were posted afterwards. Would it be possible to post more details about this?

Well, the 'temporary' fix worked, I forgot to give feedback. But there must be a reason why the base URL isn't in the sitemap without that fix...

Is it a contribution sitemap you're using or the google sitemap from the core?

minu wrote:Hello, can anyone explain me step by step how to solve this issue?I made some changes like here but it didn't work, maybe i forget some steps

straightlight wrote:I would probably have to test this directly since relative path may differ between servers.

R_D wrote:

straightlight wrote:I would probably have to test this directly since relative path may differ between servers.

Sorry for answering so late (family business..)

I've done some things myself and for no apparent reason when I altered the catalog/model/tool/image.php file
(I've only copied this line "return $this->config->get('config_url') . 'image/' . $new_image;" and pasted it over the line above changing only config_url into config_ssl ) it worked

I had to remove the steps from the other post in the sitemap controller file because of duplicate base urls in the sitemap, but it then worked... Strange isn't it?

if ($this->request->server['HTTPS']) {

if (isset($this->request->server['HTTPS']) && (($this->request->server['HTTPS'] == 'on') || ($this->request->server['HTTPS'] == '1'))) {

straightlight wrote:I also created a tweak for the site redirection library where the link would be originally use: http://forum.opencart.com/viewtopic.php ... 85#p628049 .

esk1mox wrote:Hi, Not I understand your changes in image.php file. Can you please clarify the steps IF this solved the uploading issue?

Many thanks

straightlight wrote:While one may be able to upload, since each server configurations may differ, screenshots would be inaccurate in this case since there are developed and engineered functions that are able to troubleshoot uploaded files on a web server as the reported issue only requires troubleshooting.

In admin/controller/common/filemanager.php file,

find:

Code: Select all

if (!empty($this->request->files['file']['name']) && is_file($this->request->files['file']['tmp_name'])) {

replace with:

Code: Select all

if (!empty($this->request->files['file']['name']) && is_file($this->request->files['file']['tmp_name']) && is_uploaded_file($this->request->files['file']['tmp_name'])) {

Then, try the action again. With this replacement, it not only verifies the source file but also valdates if the file has been successfully uploaded to the server.

As for this line:

Code: Select all

$filename = basename(html_entity_decode($this->request->files['file']['name'], ENT_QUOTES, 'UTF-8'));

There are three files in OC v2.2.0.0 that shows as such and I don't entirely agree with this. That being said, each should be replaced with:

Code: Select all

$filename = html_entity_decode(basename($this->request->files['file']['name']), ENT_QUOTES, 'UTF-8');

R_D wrote:

esk1mox wrote:Hi, Not I understand your changes in image.php file. Can you please clarify the steps IF this solved the uploading issue?

Many thanks

this is for uploading issues with the Image manager:

straightlight wrote:While one may be able to upload, since each server configurations may differ, screenshots would be inaccurate in this case since there are developed and engineered functions that are able to troubleshoot uploaded files on a web server as the reported issue only requires troubleshooting.

In admin/controller/common/filemanager.php file,

find:

Code: Select all

if (!empty($this->request->files['file']['name']) && is_file($this->request->files['file']['tmp_name'])) {

replace with:

Code: Select all

if (!empty($this->request->files['file']['name']) && is_file($this->request->files['file']['tmp_name']) && is_uploaded_file($this->request->files['file']['tmp_name'])) {

Then, try the action again. With this replacement, it not only verifies the source file but also valdates if the file has been successfully uploaded to the server.

As for this line:

Code: Select all

$filename = basename(html_entity_decode($this->request->files['file']['name'], ENT_QUOTES, 'UTF-8'));

There are three files in OC v2.2.0.0 that shows as such and I don't entirely agree with this. That being said, each should be replaced with:

Code: Select all

$filename = html_entity_decode(basename($this->request->files['file']['name']), ENT_QUOTES, 'UTF-8');

IP_CAM wrote:after replacing this line, in the:
oc22/admin/view/javascript/common.js
Line 152, in my OC v.2.2.0.0:
$('#modal-image a.thumbnail').on('click', function(e) {
with this line:
$('#modal-image').delegate('a.thumbnail', 'click', function(e) {
it works perfect !
Ernie

PS. And this may help, if someone uses 'illegal' white space image File Names:
http://forum.opencart.com/viewtopic.php ... 84#p625218

straightlight wrote: ↑

Wed Jun 29, 2016 1:02 am

Now that we know the above was a bug, I would suggest to apply the same fixes to the following files for OC v2.2.0.0 release:

- admin/controller/catalog/download.php file
- admin/controller/feed/google_base.php file

This should definitely rectify the issue.

As for the rest of the upload files that wasn't covered in the topic, here are the following fixes as well.

In admin/controller/extension/installer.php file,

find:

Code: Select all

if (strrchr($this->request->files['file']['name'], '.') == '.xml') {

replace with:

Code: Select all

if (is_uploaded_file($this->request->files['file']['name']) && strrchr($this->request->files['file']['name'], '.') == '.xml') {

In admin/controller/tool/upload.php file,

find:

Code: Select all

if (!empty($this->request->files['file']['name']) && is_file($this->request->files['file']['tmp_name'])) {

replace with:

Code: Select all

if (!empty($this->request->files['file']['name']) && is_file($this->request->files['file']['tmp_name']) && is_uploaded_file($this->request->files['file']['tmp_name'])) {

In your catalog/controller/tool/upload.php file,

find:

Code: Select all

if (!empty($this->request->files['file']['name']) && is_file($this->request->files['file']['tmp_name'])) {

replace with:

Code: Select all

if (!empty($this->request->files['file']['name']) && is_file($this->request->files['file']['tmp_name']) && is_uploaded_file($this->request->files['file']['tmp_name'])) {

Then, find:

Code: Select all

$filename = basename(html_entity_decode($this->request->files['file']['name'], ENT_QUOTES, 'UTF-8'));

replace with:

Code: Select all

$filename = html_entity_decode($this->request->files['file']['name'], ENT_QUOTES, 'UTF-8');

As for this line, I have no idea why it would be the only line matching for REGEXP compared to the rest of the other uploads in the platform:

Code: Select all

$filename = basename(preg_replace('/[^a-zA-Z0-9\.\-\s+]/', '', html_entity_decode($this->request->files['file']['name'], ENT_QUOTES, 'UTF-8')));

replace with:

Code: Select all

$filename = html_entity_decode($this->request->files['file']['name'], ENT_QUOTES, 'UTF-8');

If there is really something special about that line and should be the only line to where special chars should be considered throughout the rest of the same process of Opencart, at least - if there's one thing useful about GitHub would be to document the difference on that upload !