Post by hm2k » Wed Jan 28, 2009 7:00 pm

At the moment we ship with FCKeditor.

Up until recently I had only ever really used TinyMCE in wordpress, and I liked it, until I started using FCKeditor, which I like much more.

The bonus of FCKeditor over TinyMCE is it ships with a working image/file manager/uploader, where as TinyMCE it's a commercial addon.

The downside of FCKeditor, and for that matter TinyMCE is, they have a HUGE footprint to carry around.

FCKeditor is just under 4mb, while TinyMCE is just under 2mb.

I was looking at the size of OpenCart, it's about 6.31 MB, 3.76 MB of that is FCKeditor. If we took out FCKeditor, OpenCart would be under 3mb!

What I got thinking about is, due to the nature of javascript, you can actually host these anywhere, offsite if we liked, however, FCKeditor has connectors for the image/file manager/uploader, so we may have to rethink that.

I've also been looking at jwysiwyg, which is a jQuery based wysiwyg editor, and has a footprint of under 15kb. We also already carry jquery, but can use the Google Hosted version anyway.

I was looking at drupal, and their wysiwyg project looks kinda interesting. It pretty much allows you to plug any supported wysiwyg editor into the system, or use none at all, depending how you configure it.

What I was thinking about doing is doing something similar, and essentially shipping with jwysiwyg instead of FCKeditor, but allow the user to download and drop in FCKeditor if they wanted, or tinyMCE for that matter, whatever they liked.

This would however mean we'd have to rethink the image/file management/uploader, and probably make our own for use on pages such as the information pages, which could work in a similar way to how wordpress does it.
Last edited by hm2k on Wed Jan 28, 2009 7:17 pm, edited 1 time in total.

UK Web Hosting


User avatar
Global Moderator

Posts

Joined
Tue Mar 11, 2008 9:06 am
Location - UK

Post by Qphoria » Wed Jan 28, 2009 8:20 pm

for the editors.. i had thought something like the way templates work.. drop the fckeditor folder into the "editors" folder and it would show up and then you could choose it. However, there would likely be more involved with how the page knows how to load it. So maybe it could be moved to extension or plugins (if we had the hooks in place) and be accessed that way

I liked jizziwyg but it was really really limited.. even lacking tooltips, table insert, and source view
Also looks like they've discontinued support as they've crossed out their forum link

Image
Donate!|OpenCart Basics|GeoZones
Image


User avatar
Administrator

Posts

Joined
Tue Jul 22, 2008 3:02 am

Post by hm2k » Wed Jan 28, 2009 8:39 pm

Sure jwysiwyg is basic, but it works, more or less. It does need a few features adding I agree, such as a few tooltips and a source view would be handy (tables are quite complex to handle).

There's no support forum now, but it's still supported at the following links:

http://code.google.com/p/jwysiwyg/issues/list
http://groups.google.com/group/jwysiwyg-dev/

Although both appear to be idle atm.

Really, more than anything, we need to think about removing FCKeditor from OpenCart because it's HUGE, yet still support it.

But while we're at it, we might as well support TinyMCE and ship with jwysiwyg or nothing at all.

This is what I think anyway.

UK Web Hosting


User avatar
Global Moderator

Posts

Joined
Tue Mar 11, 2008 9:06 am
Location - UK

Post by Qphoria » Wed Jan 28, 2009 8:44 pm

well we certainly need something so jwysiwyg makes sense. Looking at the jwys page it shows examples on how to add unordered lists, which aren't in the demo. Perhaps there is more than meets the eye with it and there are more unshown features:

Code: Select all

Add custom controls

<style type="text/css">
    .alert { background: url('img/error.gif') no-repeat !important; }
</style>
$('#wysiwyg').wysiwyg({
    controls : {
        alertSep : { separator : true },
        alert : {
            visible   : true,
            exec      : function() { alert('Hello World'); },
            className : 'alert'
        }
    }
});

Code: Select all

Activate hidden controls

$('#wysiwyg').wysiwyg({
    controls : {
        separator04 : { visible : true },

        insertOrderedList : { visible : true },
        insertUnorderedList : { visible : true }
    }
});

Image
Donate!|OpenCart Basics|GeoZones
Image


User avatar
Administrator

Posts

Joined
Tue Jul 22, 2008 3:02 am

Post by hm2k » Wed Jan 28, 2009 9:29 pm

Indeed, you could be right.

I think it's definitely something to consider over HUGE FCKeditor.

In order to make progress with this, we need to do the following:
* Allow the editor for textareas to be changeable - we can continue to support fckeditor, while looking to move to jwysiwyg, but also support tinymce too.
* Handle image/file uploads/management as a separate thing - perhaps similar to wordpress's, then we won't need to support fckeditor's.

UK Web Hosting


User avatar
Global Moderator

Posts

Joined
Tue Mar 11, 2008 9:06 am
Location - UK

Post by hm2k » Fri Jan 30, 2009 2:41 am

FCKeditor is simply too big to lug around, it's godda go in 0.8 and once a file restructure is done, i'll allow it so users can simply drop fckeditor back in.

UK Web Hosting


User avatar
Global Moderator

Posts

Joined
Tue Mar 11, 2008 9:06 am
Location - UK

Post by Qphoria » Fri Jan 30, 2009 3:46 am

Then are we at least going to offer jwysiwyg as the default? Would seem rather unfinished if it came "out-of-the-box" with no editor

Image
Donate!|OpenCart Basics|GeoZones
Image


User avatar
Administrator

Posts

Joined
Tue Jul 22, 2008 3:02 am

Post by hm2k » Fri Jan 30, 2009 3:52 am

Yes, I'd say so, so long as it's not too problematic, otherwise we'll have to have a little rethink.

Drupal actually doesn't ship with an editor at all, you just use the textarea as normal.

Wordpress ships with a customised version of TinyMCE.

UK Web Hosting


User avatar
Global Moderator

Posts

Joined
Tue Mar 11, 2008 9:06 am
Location - UK

Post by Qphoria » Fri Jan 30, 2009 4:00 am

hm2k wrote: Drupal actually doesn't ship with an editor at all, you just use the textarea as normal.
Pfft who would actually use drupal anyway  8)

Image
Donate!|OpenCart Basics|GeoZones
Image


User avatar
Administrator

Posts

Joined
Tue Jul 22, 2008 3:02 am

Post by hm2k » Fri Feb 06, 2009 7:20 am

A step in the right direct in r436.

You can now apply whatever editor you like by editing the editor.tpl in the admin template.

We'll stick with FCKeditor for a while yet.

UK Web Hosting


User avatar
Global Moderator

Posts

Joined
Tue Mar 11, 2008 9:06 am
Location - UK
Who is online

Users browsing this forum: No registered users and 7 guests