Post by James » Sat Apr 05, 2014 5:10 am

Daniel updated the utf8 helpers on 1.5.6.1 which have been moved into a new branch now, 1.5.6.2.

Taking the opportunity to patch a few bugs with the last release before making the download public.

I have already added a few - https://github.com/opencart/opencart/commits/v1.5.6.2

If you know of any more bugs on the last release please update below (if possible with suggested fix / idea), ensure that you check the commit log before posting in case the issue has already been resolved.

I will release in 2-3 days.
Last edited by James on Mon Apr 14, 2014 11:06 pm, edited 1 time in total.

User avatar
Administrator

Posts

Joined
Wed May 27, 2009 6:07 am
Location - Leeds, UK

Post by SelfMan » Sat Apr 05, 2014 7:53 am

Hi,
I sugggested a modification the CE version.
There a is a piece of code on multiple places:

Code: Select all

 if ($this->customer->isLogged()) {
 $customer_group_id = $this->customer->getCustomerGroupId();
 } else {
 $customer_group_id = $this->config->get('config_customer_group_id');
 }
this check and set should be done directly within getCustomerGroupId() method.
I suggest to modify system\library\customer.php to:

Code: Select all

public function getCustomerGroupId() {
 if ($this->isLogged()) {
 return $this->customer_group_id;
 } else {
 return $this->config->get('config_customer_group_id');
 }
 }

New member

Posts

Joined
Thu Dec 01, 2011 8:01 am

Post by James » Sat Apr 05, 2014 10:28 pm

Thanks selfman, this release is about bug fixes though. There isn't a bug with the code, its just not as you suggest very well optimised. Good suggestion for 2.0 though which I will check through in a bit.

User avatar
Administrator

Posts

Joined
Wed May 27, 2009 6:07 am
Location - Leeds, UK

Post by rph » Sun Apr 06, 2014 8:07 am

It would be worth updating the installer to check for mbstring and/or iconv.

-Ryan


rph
Expert Member

Posts

Joined
Fri Jan 08, 2010 5:05 am
Location - Lincoln, Nebraska

Post by SelfMan » Sun Apr 06, 2014 9:20 am

James wrote:Thanks selfman, this release is about bug fixes though. There isn't a bug with the code, its just not as you suggest very well optimised. Good suggestion for 2.0 though which I will check through in a bit.
Hi James. The significant problem is that when guests are shopping, the group id is not set at all.
I found this to be a problem when an extension relies on the group id value.
Still good to know that the fix will make it to the 2.0 branch.

New member

Posts

Joined
Thu Dec 01, 2011 8:01 am

Post by James » Mon Apr 07, 2014 6:10 am

rph wrote:It would be worth updating the installer to check for mbstring and/or iconv.
Yeah I agree - added on last commit:

https://github.com/opencart/opencart/co ... ccf3b0db26

since you can have mbstring or inconv for the utf8 helper really not sure which took precedent. From what i saw mbstring is better and should also be easier to enable if neither are available. If iconv is available though it won't bother the user as it should be available in php by default now.

User avatar
Administrator

Posts

Joined
Wed May 27, 2009 6:07 am
Location - Leeds, UK

Post by sml » Wed Apr 09, 2014 8:45 pm

James wrote:Daniel updated the utf8 helpers on 1.5.6.1 which have been moved into a new branch now, 1.5.6.2.
I will release in 2-3 days.
No stress .. but just touching base on the latest release date please :)

sml
Active Member

Posts

Joined
Sat Apr 02, 2011 6:56 am

Post by James » Wed Apr 09, 2014 8:49 pm

Just working on some last few things like; a change log format and a final PayPal Express patch...and we should be good to go :) I will try to sort for later today if not tomorrow..

User avatar
Administrator

Posts

Joined
Wed May 27, 2009 6:07 am
Location - Leeds, UK

Post by sirsubliminal » Thu Apr 10, 2014 2:32 pm

There is a bug I'm surprised no one ever has mentioned.
Can't go into details because I'm not sure when/where this happens.

Sometimes (seems random) when visitors create an account (not sure if it is standalone create or in the order process) they fiddle around with their addresses and they get a customer_id 0 in the table address.

Newbie

Posts

Joined
Fri Jan 18, 2013 6:28 am

Post by rph » Thu Apr 10, 2014 2:37 pm

Which version of OpenCart are you using? I can't find any occurrences on databases I have access to.

-Ryan


rph
Expert Member

Posts

Joined
Fri Jan 08, 2010 5:05 am
Location - Lincoln, Nebraska

Post by qahar » Thu Apr 10, 2014 6:34 pm

From the title I thought the download is already available for public ;D
You should use "Release Candidate" to make it clear and give more time until it published.
Assuming that community will help 1.5.6.2 as stable as possible as if this is the latest released of 1.5.x

User avatar
Expert Member

Posts

Joined
Tue Jun 29, 2010 10:24 pm
Location - Indonesia

Post by James » Fri Apr 11, 2014 12:12 am

1.5.6.2 has now been released.

You should be able to update directly from 1.5.6.1 -> 1.5.6.2 by just updating the files - initial tests indicate everything works perfectly so unless you have 3rd party modules that have conflicts it should be an easy upgrade.

Swapping my efforts back to helping Daniel with 2.0 and OpenBay Pro but if anyone has any further bug reports please add them to the Github bug tracker and we can look at adding them for a later release.

J

User avatar
Administrator

Posts

Joined
Wed May 27, 2009 6:07 am
Location - Leeds, UK

Post by phatoa » Fri Apr 11, 2014 4:51 am

Error pp_express payment modules in file

catalog/model/payment/pp_express.php

lines:

Code: Select all

        $data['PAYMENTREQUEST_0_ITEMAMT'] = number_format($value, 2, '.', '');
        $data['PAYMENTREQUEST_0_AMT'] = number_format($value, 2, '.', '');
must change to

Code: Select all

        $data['PAYMENTREQUEST_0_ITEMAMT'] = number_format($item_total, 2, '.', '');
        $data['PAYMENTREQUEST_0_AMT'] = number_format($item_total, 2, '.', '');

Newbie

Posts

Joined
Sun Oct 20, 2013 2:49 am

Post by James » Fri Apr 11, 2014 5:34 am

Thanks phatoa.

I have added a fix for this in the next release (currently named 1.5.6.3_rc on GH). You can copy the file from here to fix the current branch:
https://github.com/opencart/opencart/bl ... xpress.php

J

User avatar
Administrator

Posts

Joined
Wed May 27, 2009 6:07 am
Location - Leeds, UK

Post by sirsubliminal » Fri Apr 11, 2014 7:05 am

rph wrote:Which version of OpenCart are you using? I can't find any occurrences on databases I have access to.


1.5.6
I should'nt be the only one with this problem.

Dont know if my theme can f things up, dont think so but Im no expert on opencart.

Newbie

Posts

Joined
Fri Jan 18, 2013 6:28 am

Post by sirsubliminal » Fri Apr 11, 2014 4:27 pm

sirsubliminal wrote:
rph wrote:Which version of OpenCart are you using? I can't find any occurrences on databases I have access to.


1.5.6
I should'nt be the only one with this problem.

Dont know if my theme can f things up, dont think so but Im no expert on opencart.
Just found out that it is not in the create a customer process this happens. Opencart seems to add rows to the table address with customer_id 0 when people buy as guest. Does not mather If I use an extension or default. It just happens sometimes.

I thought that table (address) was just for "real" customers creating an account.

Newbie

Posts

Joined
Fri Jan 18, 2013 6:28 am

Post by sirsubliminal » Fri Apr 11, 2014 4:57 pm

sirsubliminal wrote:
sirsubliminal wrote:
rph wrote:Which version of OpenCart are you using? I can't find any occurrences on databases I have access to.


1.5.6
I should'nt be the only one with this problem.

Dont know if my theme can f things up, dont think so but Im no expert on opencart.
Just found out that it is not in the create a customer process this happens. Opencart seems to add rows to the table address with customer_id 0 when people buy as guest. Does not mather If I use an extension or default. It just happens sometimes.

I thought that table (address) was just for "real" customers creating an account.
Just figured out that it is a payment module for opencart that does this. I have alerted the payment system / developers for this module about this.

Newbie

Posts

Joined
Fri Jan 18, 2013 6:28 am

Post by JNeuhoff » Sat Apr 12, 2014 3:03 am

James wrote:1.5.6.2 has now been released.

You should be able to update directly from 1.5.6.1 -> 1.5.6.2 by just updating the files - initial tests indicate everything works perfectly so unless you have 3rd party modules that have conflicts it should be an easy upgrade.

Swapping my efforts back to helping Daniel with 2.0 and OpenBay Pro but if anyone has any further bug reports please add them to the Github bug tracker and we can look at adding them for a later release.

J
Here is little bug: In file system/database/mysqli.php, line 19, should contain this:

Code: Select all

			if ($query instanceof mysqli_result) {
instead of

Code: Select all

			if (isset($query->num_rows)) {
otherwise the mysqli query return true if there are zero results.

MHC Web Design
Override Engine * Integrated VQMod * Multilingual SEO * Instant Option Price Calculator * TrustPilot Reviews * Download Options * Free Download Buttons * Export/Import Tool * Template Switcher PHP/Twig


User avatar
Expert Member

Posts

Joined
Wed Dec 05, 2007 3:38 am


Post by SelfMan » Sat Apr 12, 2014 4:53 am

I found one more (annoying) bug. When you have a list of orders and hit the print invoice button without selecting one of the orders a blank page in a popup is shown. It would be logical to display a JS warning that no order was selected and the same in the print view.

New member

Posts

Joined
Thu Dec 01, 2011 8:01 am

Post by chongshengdz » Sat Apr 12, 2014 10:31 pm

phatoa wrote:Error pp_express payment modules in file

catalog/model/payment/pp_express.php

lines:

Code: Select all

        $data['PAYMENTREQUEST_0_ITEMAMT'] = number_format($value, 2, '.', '');
        $data['PAYMENTREQUEST_0_AMT'] = number_format($value, 2, '.', '');
must change to

Code: Select all

        $data['PAYMENTREQUEST_0_ITEMAMT'] = number_format($item_total, 2, '.', '');
        $data['PAYMENTREQUEST_0_AMT'] = number_format($item_total, 2, '.', '');

thanks,phatoa,“The totals of the cart item amounts do not match order amounts.” has been fixed.

New member

Posts

Joined
Sat Apr 12, 2014 10:18 pm
Who is online

Users browsing this forum: No registered users and 3 guests