system/startup.php file - register globals bug

Quote

Post by straightlight » Tue Nov 15, 2011 8:27 am

It has been known that register_globals cannot be verified by a simple ini_get within an if statement which will simply falsify the results.

To correct this issue, from system/startup.php file,

find:

Code: Select all

if (ini_get('register_globals')) {
replace with:

Code: Select all

$register_globals = strtolower(@ini_get('register_globals'));
if ($register_globals && $register_globals == "off" && $register_globals == "false") {
Then, from install/view/template/step_2.tpl file,

find:

Code: Select all

<td><?php echo (ini_get('register_globals')) ? 'On' : 'Off'; ?></td>
replace with:

Code: Select all

<td>
<?php
$register_globals = strtolower(@ini_get('register_globals'));
if ($register_globals && $register_globals == "off" && $register_globals == "false") {
    echo 'Off';

}  elseif ($register_globals && $register_globals != "off" && $register_globals != "false") {
    echo 'On';
}
?>
</td>

Dedication and passion goes to those who are able to push and merge a project.

Regards,
Straightlight
Programmer / Opencart Tester

straightlight
Legendary Member
Posts
22391
Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON
Top
Post Reply
Return to “Bug Reports”
Who is online

Users browsing this forum: No registered users and 72 guests